Repository navigation
feat: fail fast when DOCKER_HOST points to an external daemon (workflow-scope DinD) - #1909
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workflow-scope DinD (
DOCKER_HOST=tcp://localhost:2375) silently breaks AWF because Docker Compose routes container creation through the DinD daemon's network namespace, where AWF's fixed subnet (172.30.0.0/24) and iptables DNAT rules are unreachable from the runner.Changes
Fail-fast check (
src/cli.ts):checkDockerHost()inspectsDOCKER_HOSTat startup. Any value other than the two canonical local sockets (unix:///var/run/docker.sock,unix:///run/docker.sock) exits immediately with a clear error:Documentation (
docs/usage.md): New Workflow-Scope DinD Incompatibility subsection under Limitations — explains root cause, the error message, and the--enable-dindworkaround for agents that genuinely need Docker access.Tests (
src/cli.test.ts): 7 unit tests forcheckDockerHost()covering absent/undefined env var, both valid local socket paths, TCP, TLS TCP, and non-standard unix socket.